Do not include xfId in CellStyleXfs XML #1325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes the
xfId
attribute fromxf
elements in thecellStyleXfs
collection.When writing the
styles.xml
file NPOI includes axfId
attribute in thexf
elements of the cell style format collectionThe
xfId
attribute is meaningless incellStyleXfs
collections. Thexf
record is also used in thecellXfs
collection wherexfId
is an index intocellStyleXfs
.If you load a generated file into Excel and save it the
xfId
is stripped out ofcellStyleXfs
elements.Unfortunately, inclusion of the
xfId
attribute in thecellStyleXfs
collection can cause other applications to fail. Spotfire will not read a file created with NPOI. Spotfire usesSyncfusion.XlsIO.Implementation.XmlReaders.Excel2007Parse
which will crash if anxfId
is present onxf
records in acellStyleXfs
colllection. Spotfire will read files once the fix in this PR is applied.